Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less deprecation warnings during test runs #3806

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Less deprecation warnings during test runs #3806

merged 1 commit into from
Nov 21, 2023

Conversation

bengolder
Copy link
Contributor

@bengolder bengolder commented Nov 21, 2023 •
edited
Loading

Gets rid of the DEPRECATION WARNING lines that we keep seeing during test runs. Relates to heartcombo/devise#5644

bin/test state_file
8 processes for 82 specs, ~ 10 specs per process

Randomized with seed 6944

DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at /Users/bgolder/Developer/vita-min/config/environment.rb:5)
DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at /Users/bgolder/Developer/vita-min/config/environment.rb:5)
DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at /Users/bgolder/Developer/vita-min/config/environment.rb:5)
DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at /Users/bgolder/Developer/vita-min/config/environment.rb:5)
DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at /Users/bgolder/Developer/vita-min/config/environment.rb:5)
DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at /Users/bgolder/Developer/vita-min/config/environment.rb:5)
DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at /Users/bgolder/Developer/vita-min/config/environment.rb:5)
DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at /Users/bgolder/Developer/vita-min/config/environment.rb:5)
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 1 minute 17.07 seconds (files took 11.96 seconds to load)
588 examples, 0 failures

Randomized with seed 6944

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-3806-cdd665b8fbaf.herokuapp.com/
View logs: heroku logs --app gyr-review-app-3806 (optionally add --tail)

rickreyhsig
rickreyhsig approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@rickreyhsig rickreyhsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bengolder bengolder merged commit 9fcc46e into main Nov 21, 2023
4 checks passed
@bengolder bengolder deleted the devise-credential-deprecation-warnings branch November 21, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickreyhsig rickreyhsig rickreyhsig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengolder @rickreyhsig